Skip to content

compiler: test runner: fix tests never fails on crippled architectures #24180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

xtexx
Copy link
Contributor

@xtexx xtexx commented Jun 14, 2025

Previously tests for stage2 RISC-V 64 backend are never failing. This PR fixes it and skips all currently failing rv64 behavior tests.

@alexrp
Copy link
Member

alexrp commented Jun 14, 2025

cc @Rexicon226

@mlugg
Copy link
Member

mlugg commented Jun 14, 2025

I've had a message from @Rexicon226 with feedback -- he's currently not able to reply on here, so this comment is just me relaying that feedback :P

He says that this PR is correct and overall fine to merge, but that the printing needs to be disabled (I'm guessing to avoid spamming the CI logs, which I would agree with). Looks like that would just require reverting the true in enable_print or something along those lines. Also, of course, there have been CI failures which indicate a couple more tests also need to be disabled.

@xtexx xtexx force-pushed the riscv64-tests branch 4 times, most recently from 989f05b to 60a37e6 Compare June 14, 2025 23:20
@Rexicon226
Copy link
Contributor

Thanks to @mlugg for relaying my message, was away from the keyboard for a couple weeks with only a few chances to send GitHub messages. Just wanted to disable the printing in the test runner since it spams the output logs on the CI and gets annoying to read. In my great rewrite of the backend (soon:tm:, master...Rexicon226:zig:riscv), I have the build server all working, so I'll be switching over to that.

Seems that a recent rebase is running some test that doesn't work yet on the RISC-V backend :). Disable that and the PR looks great. I had already caught this bug long ago and it kinda got stuck in my endless refactor branch.

I still have a few months of busy working before I'll get a bit more free time in my schedule, so we'll see. I hope to upstream some of that work soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants